Bad Python Practice?

[shanenin]

I would like to write good code, it is so east to start writing crap. Is the following bad.

lets say I have the following code

testvar = 5
def test(testvar):
    print testvar
test(testvar)

is it a bad practice to use the name of a variable or function in the definition of function, in particular for naming the parameter. This would seem useful to help document what is happening in your code(helps me remember). It does not seem to cause any problems

[quickbasicguru]

I don't use Python, but I believe that is good practice (a form of commenting).

[shanenin]

maybe it would be better to do this

testvar = 5
def test(_testvar):
   print _testvar
test(testvar)

[jcl]

Well, it can cause problems if one declaration masks another, and it can be confusing if it isn't clear which binding is being used, but if it's it not a problem for you I wouldn't worry. The important thing is to pick meaningful names.

Edited August 18, 2005 by jcl